New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle panic in case of empty test case file #1840
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mayank Kumar <mayankk.co@nsit.net.in> Signed-off-by: infinity <mayankk.co@nsit.net.in>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
I have read the CLA Document and I hereby sign the CLA |
recheck |
if yamlTestcase == nil { | ||
return nil, errors.New("test case not present") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kidminks the logic seems to be correct but the message can be updated with
Skipped incomplete test case: Please verify that the test case is fully specified.
hey @kidminks any update on this? |
Related Issue
Closes: #1755
Describe the changes you've made
I have added a check in testDb/utils.go > Decode() to handle nil yamlTestCase due to which panic was occurring. Decode function will return error with message test case not present incase test is empty
Type of change