add: support of custom mock name #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shivamsouravjha please resolve merge conflicts |
shivamsouravjha
force-pushed
the
shivam/mockRefactor
branch
2 times, most recently
from
48ac9ef
to
680f216
Compare
pkg/service/replay/service.go
Outdated
| @@ -63,3 +63,8 @@ type Telemetry interface { | |||
| type RequestEmulator interface { | |||
| SimulateRequest(ctx context.Context, appID uint64, tc *models.TestCase, testSetID string) (*models.HTTPResp, error) | |||
| } | |||
| type TestResult interface { | |||
| TestRunStatus(ctx context.Context, status bool, testSetID string) | |||
| MockName() string | |||
There was a problem hiding this comment.
function name cannot be a noun , how can I know what MockName, MockFile does and what are they are doing inside TestResult.
There was a problem hiding this comment.
Try to see if you use the same TestUtilInstance and add functions to it and use them.
shivamsouravjha
force-pushed
the
shivam/mockRefactor
branch
from
92575fe
to
b530cf5
Compare
Signed-off-by: shivamsouravjha <shivamsouravjha@gmail.com>
shivamsouravjha
force-pushed
the
shivam/mockRefactor
branch
from
84f5f7a
to
071363a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)