Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: server initiatied calls #1759

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AhmedLotfy02
Copy link
Contributor

Related Issue

-Incase of server initiated calls this fails as there's no listener on the server.

Closes: #1572

Describe the changes you've made

In case of SMTP: client and smtp server will initiate the protocol then the client send the mail.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
pkg/core/proxy/proxy.go Fixed Show fixed Hide fixed
pkg/core/proxy/proxy.go Fixed Show fixed Hide fixed
@AhmedLotfy02
Copy link
Contributor Author

AhmedLotfy02 commented Mar 31, 2024

@shivamsouravjha
The client and the smtp server initiated successfully
image


But while Keploy recording the outgoing and encode the Ok message from the server to send the email data it failed:

DeepinScreenshot_select-area_٢٠٢٤٠٣٣١٠٩١٨٢٩


and this is the error:

image

@shivamsouravjha shivamsouravjha self-requested a review April 1, 2024 06:22
Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
@shivamsouravjha
Copy link
Contributor

@AhmedLotfy02 can you please update the PR as many of the tests are breaking

Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GSoC]: Add support in Keploy to read from server initiated calls
2 participants