New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: intergrate logging function #1710
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: hanzili <hanzi.li@mail.mcgill.ca>
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
I have read the CLA Document and I hereby sign the CLA |
@hanzili it would be better if Keploy logs that docker daemon isn't running, reason being if someone has keploy installed, restarted laptop or stopped docker manually, once they try to run keploy they would face similar issue. So it would be better approach to rather log in keploy |
Sorry for getting back so late! Do you mean checking is docker is running when keploy starts? Could you explain more about the issue when someone restarted laptop or stopped docker manually as you mentioned? It sounds like a different issue than the one I encountered. My issue is that the keploy installation script does not initialize everything needed to run keploy (like creating |
Related Issue
When executing installation script, user can easily miss the log message and continue using keploy with a fail initlization (that's what happened to me T^T
Closes: #1701
Describe the changes you've made
log_message
for standardized and color-coded logging.Type of change
Please let us know if any test cases are added
NA
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)NA
Checklist:
Screenshots (if any)
Now, when there is an error level logging, the execution will be paused until user acknowledge the message.