-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]: permissions for keploy folder #1699
base: main
Are you sure you want to change the base?
[fix]: permissions for keploy folder #1699
Conversation
Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
@@ -155,6 +157,14 @@ | |||
utils.LogError(Logger, err, "failed to close the yaml file", zap.String("path directory", path), zap.String("yaml", fileName)) | |||
return false, err | |||
} | |||
|
|||
basePath := path[:strings.LastIndex(path, "/")] | |||
cmd := exec.Command("sudo", "chmod", "-R", "777", basePath) |
Check failure
Code scanning / CodeQL
Command built from user-controlled sources Critical
user-provided value
This command depends on a
user-provided value
@AhmedLotfy02 the CI is failing. please check |
Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EraKin575 I added path validation and sanitization but still the same.
@AhmedLotfy02 please update the PR as pipeline is failing, also fix the conflicts. |
Related Issue
Closes: #1696
Describe the changes you've made
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NA
if there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)