Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: update keploy even it has the latest version #1609

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AhmedLotfy02
Copy link
Contributor

Related Issue

  • Keploy update it's version even it has the latest one

Closes: #1608

Describe the changes you've made

  • Just remove "v" from the release tag to be the same format of what we get from binary, example v2.x.x --> 2.x.x.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Please let us know if any test cases are added

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original Updated
original screenshot updated screenshot

Signed-off-by: AhmedLotfy02 <ahmadlotfygamersfield@gmail.com>
@charankamarapu
Copy link
Member

Hi @AhmedLotfy02 we refactored the main branch . But the updated feature has been not completely tested with the refactoring . We will working on it asap once that is done we can proceed with this PR.

@AhmedLotfy02
Copy link
Contributor Author

@charankamarapu Hi, it's fixed in the refactored v2 by adding "v" prefix to version as in the screenshot provided

DeepinScreenshot_select-area_٢٠٢٤٠٣١٥٠٢٠٢١٩

@shivamsouravjha
Copy link
Contributor

shivamsouravjha commented Apr 29, 2024

hey @AhmedLotfy02 can you please update the PR to fix the conflict error

@AhmedLotfy02
Copy link
Contributor Author

@shivamsouravjha I think we could close this PR as the desired output is done on the latest version.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Keploy update command updates even on latest version
3 participants