New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ESLint 7.x #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super. Thanks!
8b03ba4
to
fc02180
Compare
@kentcdodds It seems like |
There's a circular dependency. We'll need to update both. I don't mind if it's messed up for one release, so the order shouldn't matter. |
@kentcdodds Let's first update this one then 馃檪 I still have another problem. node/exports-style node/file-extension-in-import node/no-callback-literal node/no-deprecated-api node/no-exports-assign
node/no-extraneous-import node/no-extraneous-require node/no-missing-import node/no-missing-require node/no-restricted-import
node/no-restricted-require node/no-unpublished-bin node/no-unpublished-import node/no-unpublished-require node/no-unsupported-features/es-builtins
node/no-unsupported-features/es-syntax node/no-unsupported-features/node-builtins node/prefer-global/buffer node/prefer-global/console node/prefer-global/process
node/prefer-global/text-decoder node/prefer-global/text-encoder node/prefer-global/url node/prefer-global/url-search-params node/prefer-promises/dns
node/prefer-promises/fs node/process-exit-as-throw node/shebang Should I include all |
Let's go ahead and configure those rules 馃憤 |
BREAKING CHANGE: Requires Node@^10.12.x || 12.x BREAKING CHANGE: Requires ESLint@^7.x
fc02180
to
4f47e53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thanks so much for all your work here!
Always a pleasure to help out 馃檪 |
@kentcdodds Since CI is failing tests, this one won't be released either 馃槙 |
馃帀 This PR is included in version 16.0.0 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
ESLint v7.0.0 is released 馃帀
(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:
eslint-plugin-import
(New release supporting ESLint 7聽import-js/eslint-plugin-import#1772)eslint-plugin-jest
(Support ESLint 7.x聽jest-community/eslint-plugin-jest#568)eslint@7
聽jest-community/eslint-plugin-jest#572eslint-plugin-jest-dom
(Support ESLint 7.x聽testing-library/eslint-plugin-jest-dom#45)eslint-plugin-jsx-a11y
(https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/683)eslint-plugin-react
eslint-plugin-react-hooks
(eslint-plugin-react-hooks peerDependency warning with eslint@7.0.0聽facebook/react#18876)eslint-plugin-testing-library
(Support ESLint 7.x聽testing-library/eslint-plugin-testing-library#138)eslint-find-rules
(eslint v7 support聽sarbbottam/eslint-find-rules#318)BREAKING CHANGE: Requires Node@^10.12.x || 12.x
BREAKING CHANGE: Requires ESLint@^7.x