Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies & add new rules #137

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

Dattaya
Copy link
Contributor

@Dattaya Dattaya commented Dec 26, 2023

Hi, thanks so much for sharing your great dev utils with the world.

This is an attempt to make the library work with TS5, here's what was done in this PR (in addition to updating deps and adding new rules):

  • Fixed Support for Newer TypeScript Versions #136
  • Fixed Remove unnecesary rules for react 17 and above #114
  • Removed deprecated rules
  • Bumped node version to 18 (previous are no longer supported)
  • Removed @typescript-eslint/no-duplicate-imports (because it's deprecated) and no-duplicate-imports was turned off in favor of import/no-duplicates
  • Some rules were renamed, e.g. testing-library/no-await-sync-querytesting-library/no-await-sync-queries, @typescript-eslint/no-parameter-properties@typescript-eslint/parameter-properties
  • Added typescript-version to the matrix in GH actions

If there's anything else that should be fixed, please let me know.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@kentcdodds kentcdodds merged commit d87d529 into kentcdodds:main Jan 3, 2024
5 checks passed
Copy link

github-actions bot commented Jan 3, 2024

🎉 This PR is included in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Dattaya Dattaya deleted the new-deps branch January 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Newer TypeScript Versions Remove unnecesary rules for react 17 and above
2 participants