refactor: Cleanup dependency calculation (#63)

kentcdodds · May 5, 2020 · 207b3c4 · 207b3c4
1 parent c2b55ab
commit 207b3c4
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/jest.js b/jest.js
@@ -5,18 +5,19 @@ let hasTestingLibrary = false
 
 try {
   const pkg = readPkgUp.sync({normalize: true})
-  // eslint-disable-next-line prefer-object-spread
-  const allDeps = Object.assign(
-    pkg.peerDependencies,
-    pkg.devDependencies,
-    pkg.dependencies,
-  )
-  hasJestDom = allDeps.hasOwnProperty('@testing-library/jest-dom')
-  hasTestingLibrary =
-    allDeps.hasOwnProperty('@testing-library/dom') ||
-    allDeps.hasOwnProperty('@testing-library/react') ||
-    allDeps.hasOwnProperty('@testing-library/angular') ||
-    allDeps.hasOwnProperty('@testing-library/vue')
+  const allDeps = Object.keys({
+    ...pkg.peerDependencies,
+    ...pkg.devDependencies,
+    ...pkg.dependencies,
+  })
+
+  hasJestDom = allDeps.includes('@testing-library/jest-dom')
+  hasTestingLibrary = [
+    '@testing-library/dom',
+    '@testing-library/react',
+    '@testing-library/angular',
+    '@testing-library/vue',
+  ].some(dependency => allDeps.includes(dependency))
 } catch (error) {
   // ignore error
 }