This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Changing constant regex creation.
Why: This causes issues on some versions of Node. Currently there are two issues opened for this.
How: Instead of using RegEx constructor, use RegEx literal. As the regex is constant there is no need to use the constructor.
Checklist:
This is causing issues for us as well. It's just a small change that will increase compatibility.
Current issues that should be fixed with this:
#159
#160
Any feedback is really appreciated!