Apply and enforce "black" on all Python code in the project #685

obi1kenobi · 2019-12-02T06:04:01Z

Sibling of #684.

Initially generated with running "black" on all Python files, produced with the configuration in #684. Then, manually applied fixes to make lint pass, e.g. compensating for psf/black#1161 and moving bandit's nosec comments around until bandit is happy.

All substantive changes are in #684, so please review that first. Any changes here but not in #684 are either autogenerated by black, or purely stylistic and with no functional changes.

obi1kenobi · 2019-12-02T06:07:29Z

Here is the error log with the new configuration after running black. We'll need to manually address all of these issues.

./graphql_compiler/schema_transformation/make_query_plan.py:242:84: E231 missing whitespace after ','
                value=ListValue(values=[StringValue(value=u"$" + input_filter_name),],),
                                                                                   ^
./graphql_compiler/schema_transformation/merge_schemas.py:745:80: E231 missing whitespace after ','
        directives=[_build_stitch_directive(source_field_name, sink_field_name),],
                                                                               ^
./graphql_compiler/schema_transformation/split_query.py:666:94: E231 missing whitespace after ','
        arguments=[Argument(name=Name(value=u"out_name"), value=StringValue(value=out_name),),],
                                                                                             ^
./graphql_compiler/tests/test_ir_lowering.py:213:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:243:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:274:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:292:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:329:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:351:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:383:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:402:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:636:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_ir_lowering.py:669:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_emit_output.py:111:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_emit_output.py:244:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_emit_output.py:289:86: E231 missing whitespace after ','
                {"animal_name": OutputContextField(base_name_location, GraphQLString),}
                                                                                     ^
./graphql_compiler/tests/test_emit_output.py:336:101: E501 line too long (102 > 100 characters)
                            # but it shouldn't cause any trouble since it has absolutely nothing to do
                                                                                                    ^
./graphql_compiler/tests/test_helpers.py:250:26: E231 missing whitespace after ','
        {"wanted": "Nate",},
                         ^
./graphql_compiler/tests/test_helpers.py:278:26: E231 missing whitespace after ','
        {"num_parents": 0,},
                         ^
./graphql_compiler/tests/test_helpers.py:382:101: E501 line too long (101 > 100 characters)
        # Given a SchemaInfo, a dict representation of data fitting the schema, and a connection pool
                                                                                                    ^
./graphql_compiler/tests/test_data_tools/data_tool.py:70:54: E231 missing whitespace after ','
            {"uuid": uuids["S1"], "name": "Species 1",},
                                                     ^
./graphql_compiler/tests/test_data_tools/data_tool.py:71:54: E231 missing whitespace after ','
            {"uuid": uuids["S2"], "name": "Species 2",},
                                                     ^
./graphql_compiler/tests/test_data_tools/data_tool.py:75:77: E231 missing whitespace after ','
        "Entity_Related": ({"from_uuid": uuids["S1"], "to_uuid": uuids["S2"],},),
                                                                            ^
./graphql_compiler/tests/test_data_tools/data_tool.py:77:62: E231 missing whitespace after ','
            {"from_uuid": uuids["A1"], "to_uuid": uuids["A1"],},
                                                             ^
./graphql_compiler/tests/test_data_tools/data_tool.py:78:62: E231 missing whitespace after ','
            {"from_uuid": uuids["A1"], "to_uuid": uuids["A2"],},
                                                             ^
./graphql_compiler/tests/test_data_tools/data_tool.py:79:62: E231 missing whitespace after ','
            {"from_uuid": uuids["A1"], "to_uuid": uuids["A3"],},
                                                             ^
./graphql_compiler/tests/test_data_tools/data_tool.py:80:62: E231 missing whitespace after ','
            {"from_uuid": uuids["A3"], "to_uuid": uuids["A4"],},
                                                             ^
./graphql_compiler/tests/snapshot_tests/test_cost_estimation.py:1034:90: E231 missing whitespace after ','
        nonunique_params = {"birthday_collection": [date(2017, 3, 22), date(1999, 12, 31),]}
                                                                                         ^
./graphql_compiler/tests/snapshot_tests/test_cost_estimation.py:1181:84: E231 missing whitespace after ','
            dict(), field_quantiles={("Species", "limbs"): [3, 6, 7, 9, 11, 55, 80],}
                                                                                   ^
./graphql_compiler/tests/snapshot_tests/test_cost_estimation.py:1271:98: E231 missing whitespace after ','
        small_statistics = LocalStatistics(dict(), field_quantiles={("Species", "limbs"): [3, 80],})
                                                                                                 ^
./graphql_compiler/tests/snapshot_tests/test_query_pagination.py:100:93: E231 missing whitespace after ','
                {"_paged_upper_param_on_Animal_uuid": "40000000-0000-0000-0000-000000000000",},
                                                                                            ^
./graphql_compiler/tests/snapshot_tests/test_query_pagination.py:109:93: E231 missing whitespace after ','
                {"_paged_lower_param_on_Animal_uuid": "40000000-0000-0000-0000-000000000000",},
                                                                                            ^
./graphql_compiler/tests/schema_transformation_tests/example_schema.py:43:85: E231 missing whitespace after ','
    OrderedDict([("first", basic_schema), ("second", parse(basic_additional_schema)),]),
                                                                                    ^
./graphql_compiler/tests/schema_transformation_tests/example_schema.py:90:89: E231 missing whitespace after ','
    OrderedDict([("first", basic_schema), ("second", parse(interface_additional_schema)),]),
                                                                                        ^
./graphql_compiler/tests/schema_transformation_tests/example_schema.py:153:73: E231 missing whitespace after ','
    [("first", basic_schema), ("second", parse(union_additional_schema)),]
                                                                        ^
./graphql_compiler/tests/schema_transformation_tests/test_rename_schema.py:321:85: E231 missing whitespace after ','
            {"NewCharacter": "Character", "NewDroid": "Droid", "NewHeight": "Height",},
                                                                                    ^
./graphql_compiler/tests/schema_transformation_tests/test_rename_schema.py:349:77: E231 missing whitespace after ','
            {"Human": "NewHuman", "Droid": "NewDroid", "stitch": "NewStitch",},
                                                                            ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:22:94: E231 missing whitespace after ','
            OrderedDict([("basic", parse(ISS.basic_schema)), ("enum", parse(ISS.enum_schema)),]),
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:60:66: E231 missing whitespace after ','
            OrderedDict([("basic", basic_ast), ("enum", enum_ast),]), [],
                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:171:93: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.basic_schema)),]
                                                                                            ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:195:99: E231 missing whitespace after ','
                    [("basic", parse(ISS.basic_schema)), ("bad", parse(interface_conflict_schema)),]
                                                                                                  ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:202:99: E231 missing whitespace after ','
                    [("bad", parse(interface_conflict_schema)), ("basic", parse(ISS.basic_schema)),]
                                                                                                  ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:227:94: E231 missing whitespace after ','
                    [("basic", parse(ISS.basic_schema)), ("bad", parse(enum_conflict_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:234:94: E231 missing whitespace after ','
                    [("bad", parse(enum_conflict_schema)), ("basic", parse(ISS.basic_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:294:96: E231 missing whitespace after ','
                    [("basic", parse(ISS.basic_schema)), ("bad", parse(scalar_conflict_schema)),]
                                                                                               ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:301:96: E231 missing whitespace after ','
                    [("bad", parse(scalar_conflict_schema)), ("basic", parse(ISS.basic_schema)),]
                                                                                               ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:358:94: E231 missing whitespace after ','
                    [("enum", parse(ISS.enum_schema)), ("bad", parse(scalar_conflict_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:365:94: E231 missing whitespace after ','
                    [("bad", parse(scalar_conflict_schema)), ("enum", parse(ISS.enum_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:392:93: E231 missing whitespace after ','
                [("first", parse(ISS.scalar_schema)), ("second", parse(extra_scalar_schema)),]
                                                                                            ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:446:99: E231 missing whitespace after ','
                [("first", parse(ISS.directive_schema)), ("second", parse(extra_directive_schema)),]
                                                                                                  ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:518:93: E231 missing whitespace after ','
                OrderedDict([("", parse(ISS.basic_schema)), ("enum", parse(ISS.enum_schema)),]), [],
                                                                                            ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:523:92: E231 missing whitespace after ','
                    [("hello\n", parse(ISS.basic_schema)), ("enum", parse(ISS.enum_schema)),]
                                                                                           ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:539:97: E231 missing whitespace after ','
                OrderedDict([("\t\b", parse(ISS.basic_schema)), ("enum", parse(ISS.enum_schema)),]),
                                                                                                ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:544:93: E231 missing whitespace after ','
                OrderedDict([(42, parse(ISS.basic_schema)), ("enum", parse(ISS.enum_schema)),]), [],
                                                                                            ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:554:64: E231 missing whitespace after ','
                OrderedDict([("first", parse(ISS.basic_schema)),]), [],
                                                               ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:562:94: E231 missing whitespace after ','
                [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:605:88: E231 missing whitespace after ','
            OrderedDict([("first", basic_schema_ast), ("second", same_field_schema_ast),]),
                                                                                       ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:625:94: E231 missing whitespace after ','
                [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:684:95: E231 missing whitespace after ','
                [("first", parse(ISS.basic_schema)), ("second", parse(multiple_fields_schema)),]
                                                                                              ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:744:94: E231 missing whitespace after ','
                [("first", parse(ISS.basic_schema)), ("second", parse(non_null_field_schema)),]
                                                                                             ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:804:98: E231 missing whitespace after ','
                [("first", parse(ISS.scalar_schema)), ("second", parse(additional_scalar_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:864:96: E231 missing whitespace after ','
            OrderedDict([("first", parse(ISS.basic_schema)), ("second", parse(id_field_schema)),]),
                                                                                               ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:934:96: E231 missing whitespace after ','
            OrderedDict([("first", parse(int_field_schema)), ("second", parse(id_field_schema)),]),
                                                                                               ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:978:97: E231 missing whitespace after ','
                    [("first", parse(ISS.union_schema)), ("second", parse(ISS.interface_schema)),]
                                                                                                ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:998:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1018:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1038:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1058:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1078:92: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.enum_schema)),]
                                                                                           ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1098:97: E231 missing whitespace after ','
                    [("first", parse(ISS.union_schema)), ("second", parse(ISS.interface_schema)),]
                                                                                                ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1118:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1154:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(clashing_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1174:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(ISS.same_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/schema_transformation_tests/test_merge_schemas.py:1409:98: E231 missing whitespace after ','
                    [("first", parse(ISS.basic_schema)), ("second", parse(non_null_field_schema)),]
                                                                                                 ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:428:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 1",},
                                                   ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:446:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 1",},
                                                   ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:447:71: E231 missing whitespace after ','
                [{"child_names": ["Animal 1", "Animal 2", "Animal 3"]},],
                                                                      ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:460:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 4",},
                                                   ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:474:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 4",},
                                                   ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:475:37: E231 missing whitespace after ','
                [{"child_names": []},],
                                    ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:501:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 1",},
                                                   ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:521:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 1",},
                                                   ^
./graphql_compiler/tests/integration_tests/test_backends_integration.py:543:52: E231 missing whitespace after ','
                {"starting_animal_name": "Animal 1",},
                                                   ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:35:72: E231 missing whitespace after ','
        "properties": [{"name": "name", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:55:95: E231 missing whitespace after ','
BABY = frozendict({"name": "Baby", "abstract": False, "superClass": "Person", "properties": [],})
                                                                                              ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:83:84: E231 missing whitespace after ','
            {"name": "in", "type": PROPERTY_TYPE_LINK_ID, "linkedClass": "Location",},
                                                                                   ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:84:83: E231 missing whitespace after ','
            {"name": "out", "type": PROPERTY_TYPE_LINK_ID, "linkedClass": "Person",},
                                                                                  ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:96:84: E231 missing whitespace after ','
            {"name": "in", "type": PROPERTY_TYPE_LINK_ID, "linkedClass": "Location",},
                                                                                   ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:97:81: E231 missing whitespace after ','
            {"name": "out", "type": PROPERTY_TYPE_LINK_ID, "linkedClass": "Baby",},
                                                                                ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:108:79: E231 missing whitespace after ','
        "properties": [{"name": "description", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                              ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:127:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_1", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:136:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_2", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:145:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_3", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:154:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_4", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:163:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_5", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:178:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_6", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/tests/schema_generation_tests/test_orientdb_schema_generation.py:190:88: E231 missing whitespace after ','
        "properties": [{"name": "arbitrary_property_7", "type": PROPERTY_TYPE_STRING_ID,}],
                                                                                       ^
./graphql_compiler/schema/__init__.py:51:74: E231 missing whitespace after ','
    locations=[DirectiveLocation.FIELD, DirectiveLocation.INLINE_FRAGMENT,],
                                                                         ^
./graphql_compiler/schema/__init__.py:73:39: E231 missing whitespace after ','
    locations=[DirectiveLocation.FIELD,],
                                      ^
./graphql_compiler/schema/__init__.py:89:101: E501 line too long (105 > 100 characters)
                    description="What to designate the output field generated from this property field.",
                                                                                                    ^
./graphql_compiler/schema/__init__.py:94:39: E231 missing whitespace after ','
    locations=[DirectiveLocation.FIELD,],
                                      ^
./graphql_compiler/schema/__init__.py:121:98: E231 missing whitespace after ','
OutputSourceDirective = GraphQLDirective(name="output_source", locations=[DirectiveLocation.FIELD,])
                                                                                                 ^
./graphql_compiler/schema/__init__.py:130:89: E231 missing whitespace after ','
OptionalDirective = GraphQLDirective(name="optional", locations=[DirectiveLocation.FIELD,])
                                                                                        ^
./graphql_compiler/schema/__init__.py:173:81: E231 missing whitespace after ','
FoldDirective = GraphQLDirective(name="fold", locations=[DirectiveLocation.FIELD,])
                                                                                ^
./graphql_compiler/schema/__init__.py:200:39: E231 missing whitespace after ','
    locations=[DirectiveLocation.FIELD,],
                                      ^
./graphql_compiler/macros/macro_edge/directives.py:46:39: E231 missing whitespace after ','
    locations=[DirectiveLocation.FIELD,],
                                      ^
./graphql_compiler/macros/macro_edge/directives.py:52:74: E231 missing whitespace after ','
    locations=[DirectiveLocation.FIELD, DirectiveLocation.INLINE_FRAGMENT,],
                                                                         ^
./graphql_compiler/macros/macro_edge/directives.py:69:87: E231 missing whitespace after ','
    {FoldDirective, FilterDirective, OptionalDirective, TagDirective, RecurseDirective,}.union(
                                                                                      ^
./graphql_compiler/macros/macro_edge/expansion.py:17:78: E231 missing whitespace after ','
    directives_supported_at_macro_expansion = frozenset({FilterDirective.name,})
                                                                             ^
./graphql_compiler/macros/macro_edge/expansion.py:96:101: E501 line too long (105 > 100 characters)
                    u"is not a subtype of {field_type}. Only coercions to a subtype are allowed.".format(
                                                                                                    ^
./graphql_compiler/macros/macro_edge/validation.py:228:101: E501 line too long (117 > 100 characters)
            extra_error_text = u"{} is a subclass of {}, which is where you attempted to define a macro edge".format(
                                                                                                    ^
./graphql_compiler/macros/macro_edge/validation.py:256:101: E501 line too long (119 > 100 characters)
            extra_error_text = u"{} is a subclass of {}, which is where your macro edge definition points to. ".format(
                                                                                                    ^
./graphql_compiler/schema_generation/sqlalchemy/scalar_type_mapper.py:114:101: E501 line too long (102 > 100 characters)
        # We shouldn't map the Postgresql bit type to the GraphQLBoolean type. The Postgresql bit type
                                                                                                    ^
./graphql_compiler/schema_generation/orientdb/schema_graph_builder.py:309:72: E231 missing whitespace after ','
        {ORIENTDB_BASE_VERTEX_CLASS_NAME, ORIENTDB_BASE_EDGE_CLASS_NAME,}
                                                                       ^
./graphql_compiler/schema_generation/orientdb/schema_properties.py:17:84: E231 missing whitespace after ','
UNIQUE_INDEX_TYPES = frozenset({ORDERED_UNIQUE_INDEX_TYPE, HASHED_UNIQUE_INDEX_TYPE,})
                                                                                   ^
./graphql_compiler/schema_generation/orientdb/schema_properties.py:18:96: E231 missing whitespace after ','
NON_UNIQUE_INDEX_TYPES = frozenset({ORDERED_NON_UNIQUE_INDEX_TYPE, HASHED_NON_UNIQUE_INDEX_TYPE,})
                                                                                               ^
./graphql_compiler/schema_generation/orientdb/schema_properties.py:19:90: E231 missing whitespace after ','
ORDERED_INDEX_TYPES = frozenset({ORDERED_UNIQUE_INDEX_TYPE, ORDERED_NON_UNIQUE_INDEX_TYPE,})
                                                                                         ^
./graphql_compiler/compiler/metadata.py:266:101: E501 line too long (108 > 100 characters)
        return u"QueryMetadataTable(root_location={}, locations={}, inputs={}, outputs={}, tags={})".format(
                                                                                                    ^

… fix it.

…issue.

codecov · 2019-12-02T20:21:43Z

Codecov Report

Merging #685 into master will not change coverage.
The diff coverage is 84.4%.

@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files          96       96           
  Lines        7485     7485           
=======================================
  Hits         7057     7057           
  Misses        428      428

Impacted Files	Coverage Δ
graphql_compiler/compiler/subclass.py	`93.33% <ø> (ø)`	⬆️
...ql_compiler/compiler/ir_lowering_match/__init__.py	`100% <ø> (ø)`	⬆️
...hql_compiler/schema_transformation/rename_query.py	`97.72% <ø> (ø)`	⬆️
...r/compiler/ir_lowering_common/location_renaming.py	`97.05% <ø> (ø)`	⬆️
graphql_compiler/query_pagination/__init__.py	`69.56% <ø> (ø)`	⬆️
..._compiler/compiler/ir_lowering_gremlin/__init__.py	`100% <ø> (ø)`	⬆️
...raphql_compiler/query_formatting/sql_formatting.py	`100% <ø> (ø)`	⬆️
..._compiler/schema_generation/sqlalchemy/__init__.py	`66.66% <ø> (ø)`	⬆️
...l_compiler/compiler/ir_lowering_cypher/__init__.py	`100% <ø> (ø)`	⬆️
...aphql_compiler/schema_generation/orientdb/utils.py	`100% <ø> (ø)`	⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 896fec6...d137cf5. Read the comment docs.

obi1kenobi added 2 commits December 2, 2019 00:51

Output of running "black" on all Python files in the repo.

e6abbf5

Add black dependency and configure tools to avoid conflicts.

0a2d020

obi1kenobi added the maintainer quality-of-life Features that ease development, but are not necessarily visible to package users. label Dec 2, 2019

obi1kenobi requested a review from pmantica1 December 2, 2019 06:04

obi1kenobi added 3 commits December 2, 2019 15:09

Fix E501 errors by hand. Disable E231 enforcement since black doesn't…

df209bd

… fix it.

Reformat the setup.py file with black.

93bef95

Remove D202 which black sometimes violates. Fix one more line length …

e9a553d

…issue.

obi1kenobi added 4 commits December 2, 2019 16:00

Merge branch 'make_code_black' into black_transformed_output

720fd13

Update pydocstyle and flake8 error checks to ones compatible with black.

92fe9a5

Fix unused loop variable.

49b767a

Merge branch 'make_code_black' into black_transformed_output

aa3973e

obi1kenobi mentioned this pull request Dec 2, 2019

Add black dependency and configure tools to avoid conflicts. #684

Closed

Fix positioning of nosec comment.

d137cf5

obi1kenobi changed the title ~~Output of running "black" on all Python files in the repo.~~ Apply and enforce "black Dec 2, 2019

obi1kenobi changed the title ~~Apply and enforce "black~~ Apply and enforce "black" on all Python code in the project Dec 2, 2019

pmantica1 approved these changes Dec 2, 2019

View reviewed changes

pmantica1 merged commit d71f5f7 into master Dec 2, 2019

pmantica1 deleted the black_transformed_output branch December 2, 2019 23:00

obi1kenobi mentioned this pull request Dec 17, 2019

Update graphql-core version #708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply and enforce "black" on all Python code in the project #685

Apply and enforce "black" on all Python code in the project #685

obi1kenobi commented Dec 2, 2019 •

edited

obi1kenobi commented Dec 2, 2019

codecov bot commented Dec 2, 2019 •

edited

Apply and enforce "black" on all Python code in the project #685

Apply and enforce "black" on all Python code in the project #685

Conversation

obi1kenobi commented Dec 2, 2019 • edited

obi1kenobi commented Dec 2, 2019

codecov bot commented Dec 2, 2019 • edited

Codecov Report

obi1kenobi commented Dec 2, 2019 •

edited

codecov bot commented Dec 2, 2019 •

edited