Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing tests #67

Merged
merged 1 commit into from Mar 24, 2021
Merged

fix failing tests #67

merged 1 commit into from Mar 24, 2021

Conversation

JJdeVries
Copy link
Collaborator

@JJdeVries JJdeVries commented Mar 8, 2021

Add the pytest-runner to the test requirements such that the tests succeed again. For more info see also:
https://docs.pytest.org/en/reorganize-docs/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner

If pytest-runner is not an option to use we could also do the manual integration specified there.

@JJdeVries
Copy link
Collaborator Author

@fabaff @kennedyshead This ensures the tests succeed again, is this okay with you instead of the install_requires?

@kennedyshead kennedyshead merged commit cb75836 into master Mar 24, 2021
@JJdeVries JJdeVries deleted the feature/fix-tests branch March 24, 2021 07:34
@fabaff
Copy link
Contributor

fabaff commented Mar 24, 2021

setup.py test is going to be deprecated: pytest-dev/pytest#5534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants