Fix overflow bug. See issue #776 #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably happened while improperly applying a pathc from OpenBSD bcrypt sources. Tests weren't so robust I guess. |
fast-facts
pushed a commit
to fast-facts/node.bcrypt.js
that referenced
this pull request
Jun 17, 2022
Fix overflow bug. See issue kelektiv#776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #776
See comments here:
#776 (comment)
#776 (comment)
The question is sort of "how much" to fix this one. I left version 2a as is, which will use all 254 bytes of the input and wrap thereafter. This patch fixes 2b only.