Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement retry-interval when draining nodes #188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

omgrr
Copy link

@omgrr omgrr commented Jan 12, 2024

This addresses #185 by re-adding the retryInterval when draining.

This also re-adds the retry-go package in order to do both the retry and the delay functionality. If there was another reason for removing it let me know!

Testing this on an actual cluster with setting the drain-interval to 30 seconds and the drain-timeout to 120 seconds I can see from the logs that there is the correct amount of time between retries.

time="2024-01-12T19:32:06Z" level=info msg="retrying drain, node <node name>"
time="2024-01-12T19:34:36Z" level=info msg="retrying drain, node <node name>"
# 2 minutes 30 seconds between retries

omgrr and others added 2 commits January 12, 2024 16:06
Co-authored-by: Jerome Wisniewski <jwisniewski@paypal.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant