Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about correct usage of configure_project #3707

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Mar 13, 2024

Description

Fix #3704. This is tricky to resolve just with the error message. If users are using Kedro with multiprocessing themselves, they need to handle logging and configure_project carefully. There are no public API that we provide for user.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@astrojuanlu
Copy link
Member

@noklam Do you intend to keep working on this? Otherwise we can close the PR and properly groom the issue at some other time

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create documentation of the usage of configure_project
2 participants