Allow nested folder structure in pipeline creation #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend name argument of kedro pipeline create to accept dots as folder separator. Make the test directory structure mirror the pipelines structure Only include the final pipeline name in the parameters Force the pipeline name to be globally unique (no two subfolders with the same pipeline names) Signed-off-by: Gabriel Cournelle <gabriel.cournelle@gmail.com>
Signed-off-by: Gabriel Cournelle <gabriel.cournelle@gmail.com>
As the parameters file only include the final pipeline name, modify the files to iterate through. Raise an error if a pipeline to delete has a child pipeline Signed-off-by: Gabriel Cournelle <gabriel.cournelle@gmail.com>
As there can be several types of templates, forcing a pipeline to have an __init__.py to be valid seems like a bad idea. Instead, any valid py file in a subfolder will prevent deletion of the parent test_pipeline. Signed-off-by: Gabriel Cournelle <gabriel.cournelle@gmail.com>
Various tweaks to tests for create and delete pipeline. Note that to ensure that creation succeeds even if child pipeline already exists, we need to set overwrite_if_exists to True in cookiecutter function. Signed-off-by: Gabriel Cournelle <gabriel.cournelle@gmail.com>
Identify all the pipelines and raise error if two pipelines have the same name. Add associated tests Signed-off-by: Gabriel Cournelle <gabriel.cournelle@gmail.com>
This was referenced Oct 2, 2023
|
Hi @Gabriel2409, thanks a lot for submitting this PR and sorry for the delay! This is a change that needs careful review and we are a bit busy doing the final work on the Kedro 0.19 release. We will get to your PR soon 🙏🏽 |
merelcht
added
Stage: Technical Design 🎨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was created as support for discussion for issue #3105
Its goal is to enhance the kedro cli (pipeline create and delete) as well as the find_pipelines function to natively work with nested folder structure.
Development notes
create_pipeline,delete_pipelineandfind_pipelineswere modified and the associated unit tests were created.Note that I had to put overwrite_if_exists to True in cookiecutter to allow creating a pipeline if a child pipeline already exists.
Checklist
RELEASE.mdfile