Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin black in test_requirements to higher version to solve click complaints #1382

Merged
merged 3 commits into from Mar 29, 2022
Merged

Pin black in test_requirements to higher version to solve click complaints #1382

merged 3 commits into from Mar 29, 2022

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Mar 29, 2022 •
edited

Signed-off-by: Merel Theisen merel.theisen@quantumblack.com

Description

The latest click 8.1.0 is incompatible with black versions < 22.3.0

pallets/click#2232
psf/black#2964

Development notes

Bumped & pinned black to the latest version.
PR for starters: kedro-org/kedro-starters#77

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@merelcht
Pin black to higher version to solve click complaints
e45132d 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht requested a review from idanov as a code owner March 29, 2022 12:48
@merelcht merelcht self-assigned this Mar 29, 2022
@merelcht merelcht requested review from lorenabalan, antonymilne, noklam and SajidAlamQB and removed request for idanov and antonymilne March 29, 2022 12:53
@merelcht
Apply suggestions from code review
0061074 
Co-authored-by: Lorena Bălan <lorena.balan@quantumblack.com>
lorenabalan
lorenabalan approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this so quickly! 👏 I am a little bit confused though. The old ~=22.0 would've still got the newest black so I'm not entirely sure why click was complaining on our side.

@noklam
Copy link
Contributor

noklam commented Mar 29, 2022

Seems black 22.1.0 introduce prefix ordering and thus changing quite a few files, all the format string "fr" -> "rf"

See psf/black#2297

@merelcht
Copy link
Member Author

Thank you for addressing this so quickly! 👏 I am a little bit confused though. The old ~=22.0 would've still got the newest black so I'm not entirely sure why click was complaining on our side.

I wonder if it's because 22.1.0 does fulfil the requirement and it's not forcing it to update?

@merelcht
Revert + only pin test_reqs
7c25e09 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Copy link
Member Author

Thank you for addressing this so quickly! 👏 I am a little bit confused though. The old ~=22.0 would've still got the newest black so I'm not entirely sure why click was complaining on our side.

I wonder if it's because 22.1.0 does fulfil the requirement and it's not forcing it to update?

Actually, turns out we just hadn't updated black in test_requirements. So I've reverted the other changes.

@merelcht merelcht changed the title Pin black to higher version to solve click complaints Pin black in test_requirements to higher version to solve click complaints Mar 29, 2022
@merelcht merelcht merged commit f7020f7 into develop Mar 29, 2022
@merelcht merelcht deleted the fix/black-click-error branch March 29, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenabalan lorenabalan lorenabalan approved these changes

@noklam noklam noklam approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@merelcht @noklam @lorenabalan @SajidAlamQB