Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include expandAllPipelines flag in initial state #1896

Merged
merged 24 commits into from
May 20, 2024
Merged

Include expandAllPipelines flag in initial state #1896

merged 24 commits into from
May 20, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented May 9, 2024 •
edited

Description

Resolves #1883

Development notes

  • Add expandAllPipelines to Initial state object
  • Modify applyingURLParams to pipeline and non-pipeline state
  • Validate the url param expandAllPipelines without breaking the UI using isValidBoolean helper function
  • Update tests

expandAll_initial_state_fix

QA notes

  • On initial load of Kedro-Viz, expandAllPipelines query param in the URL should not be undefined
  • All tests should pass

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla
merge main from remote
0e7f24d 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
c1aae75 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
merging remote
177ccbc 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
8ecf9bf 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
Merge branch 'main' of https://github.com/kedro-org/kedro-viz
37f3bf4 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
add expandAllPipelines to initial state flags
9715a24 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update file permissions
c5c7cd9 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix tests and add release note
894e0a2 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review May 9, 2024 03:41
@ravi-kumar-pilla ravi-kumar-pilla requested review from Huongg and removed request for astrojuanlu May 9, 2024 03:41
@ravi-kumar-pilla
make expandAllPipelines outside of flags
499460c 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
revert previous change
fc81126 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as draft May 14, 2024 03:56
@ravi-kumar-pilla
merge main
fa450c4 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
add expandAllPipelines to nonPipelineState as before
40a3418 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update comments
d37c1c9 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
testing strawberry fix
9c43280 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
testing strawberry fix
1f5f871 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix strawberry graphql 0.228.0 release doc
40480a1 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
fix boolean check
478031a 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update tests
0b5a886 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review May 14, 2024 23:49
rashidakanchwala
rashidakanchwala reviewed May 16, 2024
View reviewed changes
RELEASE.md Outdated Show resolved Hide resolved
@ravi-kumar-pilla
test ci failure
425c92f 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
@ravi-kumar-pilla
update release note
d17749f 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
rashidakanchwala
rashidakanchwala approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ravi-kumar-pilla

@ravi-kumar-pilla
merge main
9727e3f 
Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
SajidAlamQB
SajidAlamQB approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ravi-kumar-pilla this looks great! 🔥

@ravi-kumar-pilla ravi-kumar-pilla merged commit 1e208b3 into main May 20, 2024
13 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/undefined-expandAllFlag branch May 20, 2024 16:16
This was referenced May 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@jitu5 jitu5 Awaiting requested review from jitu5 jitu5 is a code owner

@Huongg Huongg Awaiting requested review from Huongg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined Value for expandAllPipelines Flag after Removal from config.js
3 participants
@ravi-kumar-pilla @rashidakanchwala @SajidAlamQB