Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Flowchart models from dataclass to pydantic base models #1565

Merged
merged 41 commits into from Nov 14, 2023
Merged

Refactor Flowchart models from dataclass to pydantic base models #1565

merged 41 commits into from Nov 14, 2023

Commits on Oct 2, 2023

  1. create pydantic flowchart classes 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    a2636f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. fixing pydantic class conversions 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    240a383 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. minor modifications and code comments 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    772ed02 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. fix pytests for flowchart and managers 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    900fb70 View commit details
    Browse the repository at this point in the history

  2. fix pytests 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    57811a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. fix lint errors and pytests 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    182be16 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/kedro-org/kedro-viz into ch… 

    …ore/refactor-data-classes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    62efd72 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/kedro-org/kedro-viz into ch… 

    …ore/refactor-data-classes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    47cc4d7 View commit details
    Browse the repository at this point in the history

  4. fix lint issues and merge main 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d82f71d View commit details
    Browse the repository at this point in the history

  5. fix initialization issues and lint issues 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    fe67d26 View commit details
    Browse the repository at this point in the history

  6. fix push issue 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    47d3211 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge branch 'main' into chore/refactor-data-classes

    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1696c81 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. revert class method to static method 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c30e102 View commit details
    Browse the repository at this point in the history

  2. merge main 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2406458 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'chore/refactor-data-classes' of https://github.com/kedr… 

    …o-org/kedro-viz into chore/refactor-data-classes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    e620bcb View commit details
    Browse the repository at this point in the history

  4. update method comments 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5ec1451 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/kedro-org/kedro-viz into ch… 

    …ore/refactor-data-classes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    15855e2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into chore/refactor-data-classes

    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5c97bbf View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Merge branch 'chore/refactor-data-classes' of https://github.com/kedr… 

    …o-org/kedro-viz into chore/refactor-data-classes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    198e946 View commit details
    Browse the repository at this point in the history

  2. revert back method shuffles for better PR reviews 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3175df5 View commit details
    Browse the repository at this point in the history

  3. addressing PR comments 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    38d0029 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. merge main 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    c82e04c View commit details
    Browse the repository at this point in the history

  2. not-working version of pydantic shift 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    b106ad8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. non-working p2 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    1a95fd3 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. not-working v3 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    844531d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. modify metadata classes and update pytests 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    20bf139 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. merge main 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a7564bd View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. fix all pytests 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c526956 View commit details
    Browse the repository at this point in the history

  2. fix pytest for coverage 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f61deb9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into chore/refactor-data-classes

    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ff39824 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into chore/refactor-data-classes

    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d7e2653 View commit details
    Browse the repository at this point in the history

  5. address PR comments1 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    74b2930 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'chore/refactor-data-classes' of https://github.com/kedr… 

    …o-org/kedro-viz into chore/refactor-data-classes

Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b0e34ef View commit details
    Browse the repository at this point in the history

  7. fix lint issues 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ca6b16f View commit details
    Browse the repository at this point in the history

  8. add hash for pylint 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    2970e9e View commit details
    Browse the repository at this point in the history

  9. merge main 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    50c9d08 View commit details
    Browse the repository at this point in the history

  10. fix lint errors 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    80848d5 View commit details
    Browse the repository at this point in the history

  11. fix lint errors 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5cc645a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge branch 'main' into chore/refactor-data-classes

    @tynandebold
    tynandebold committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8e53a76 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. create base class for tag and registered pipeline 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6ce4e37 View commit details
    Browse the repository at this point in the history

  2. add release note 

    Signed-off-by: ravi-kumar-pilla <ravi_kumar_pilla@mckinsey.com>
    @ravi-kumar-pilla
    ravi-kumar-pilla committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bb51814 View commit details
    Browse the repository at this point in the history