Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go/sdk/azidentity` #5471

JorTurFer · 2024-02-02T00:43:04Z

This PR has migrated some old Azure SDKs into the (unified) new one

EventHub: github.com/Azure/azure-event-hubs-go/v3 -> github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs
Blob Storage: github.com/Azure/azure-storage-blob-go -> github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
Storage queues: github.com/Azure/azure-storage-queue-go -> github.com/Azure/azure-sdk-for-go/sdk/storage/azqueue
Azure Key Vault: github.com/Azure/azure-sdk-for-go -> github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets
Azure Monitor: github.com/Azure/azure-sdk-for-go -> github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
Azure Log Analytics: no-sdk -> github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
Azure Data Explorer: github.com/Azure/azure-kusto-go/kusto uses github.com/Azure/azure-sdk-for-go/sdk/azidentity
Azure Application Insights: Currently it's not supported, I've opened and issue asking for it for migrating it in the future

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable) chore: Update docs to reflect changes in eventhub after the SDK migration keda-docs#1313
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5470

JorTurFer · 2024-02-02T00:44:04Z

/run-e2e azure
Update: You can check the progress here

pkg/scalers/azure_data_explorer_scaler_test.go

JorTurFer · 2024-02-02T00:46:58Z

pkg/scalers/azure_eventhub_scaler.go

-	meta.eventHubInfo.EventHubResourceURL = azure.DefaultEventhubResourceURL
-	if val, ok := config.TriggerMetadata["cloud"]; ok {
-		if strings.EqualFold(val, azure.PrivateCloud) {
-			if resourceURL, ok := config.TriggerMetadata["eventHubResourceURL"]; ok {
-				meta.eventHubInfo.EventHubResourceURL = resourceURL
-			} else {
-				return fmt.Errorf("eventHubResourceURL must be provided for %s cloud type", azure.PrivateCloud)
-			}
-		}
-	}


I haven't been able to find where is this used in the new SDK. From my understanding, this was used for requesting the tokens (we requested them using http client) and now the SDK manages it in a better way

pkg/scalers/azure_eventhub_scaler.go

JorTurFer · 2024-02-02T16:11:04Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-02T17:08:20Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-02T17:42:40Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-02T18:43:17Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-02T21:26:28Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-06T00:13:12Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-06T01:06:19Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-06T22:07:19Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-02-13T21:09:15Z

/run-e2e azure
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer · 2024-03-30T16:38:05Z

/run-e2e azure
Update: You can check the progress here

JorTurFer · 2024-03-30T16:38:07Z

/run-e2e azure
Update: You can check the progress here

zroubalik

@JorTurFer what is the status on this please?

JorTurFer · 2024-04-10T18:15:12Z

It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity.

zroubalik · 2024-04-10T18:33:54Z

It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity.

Okay, sounds good!

JorTurFer commented Feb 2, 2024

View reviewed changes

pkg/scalers/azure_data_explorer_scaler_test.go Show resolved Hide resolved

JorTurFer commented Feb 2, 2024

View reviewed changes

pkg/scalers/azure_eventhub_scaler.go Show resolved Hide resolved

JorTurFer changed the title ~~Migrate Azure EventHub and Azure Storage SDKs~~ Migrate old Azure SDKs into github.com/Azure/azure-sdk-for-go Feb 2, 2024

JorTurFer changed the title ~~Migrate old Azure SDKs into github.com/Azure/azure-sdk-for-go~~ Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity Feb 6, 2024

JorTurFer mentioned this pull request Feb 6, 2024

Support Application Insights querying Azure/azure-sdk-for-go#22355

Open

JorTurFer marked this pull request as ready for review February 13, 2024 21:08

JorTurFer requested a review from a team as a code owner February 13, 2024 21:08

zroubalik approved these changes Feb 29, 2024

View reviewed changes

JorTurFer mentioned this pull request Mar 11, 2024

add core logic to support access token in postgres scaler #5589

Draft

7 tasks

JorTurFer added 10 commits March 30, 2024 17:19

Migrate EventHub SDK

fb234fe

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

remove old sdk

3b229e0

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

sort

1dd3535

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

sort

35b8ed3

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

migrate storage SDK

db07b38

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

update changelog and style

e014bf8

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

add missing change

72c6ce9

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

migrate key vault

1a7df37

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

fix typos

8dc757a

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Update azure monitor

72a38f2

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer added 12 commits March 30, 2024 17:19

fix typo

ecda21f

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

fix e2e tests

d7ce275

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

fix error

fb4096a

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

use AZQUERY FOR MONITOR

292e18c

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

fix style

f00ce08

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

use client optiosn

65a2027

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

use sdk parsing function

9b126ce

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

migrate log analytics

5d9a062

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

update tokens

4e84b8d

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

style

59c8c01

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

fix typo

be0726e

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

Add missing changes

40c04ea

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

JorTurFer force-pushed the migrate-eventhub-sdk branch from 96bc418 to 40c04ea Compare March 30, 2024 16:33

bump azure deps

a81a580

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

zroubalik reviewed Apr 10, 2024

View reviewed changes

tomkerkhove mentioned this pull request Apr 16, 2024

Release: 2.14 #5671

Closed

35 tasks

JorTurFer mentioned this pull request May 4, 2024

chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #5782

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go/sdk/azidentity` #5471

Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go/sdk/azidentity` #5471

JorTurFer commented Feb 2, 2024 •

edited

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer Feb 2, 2024

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

JorTurFer commented Feb 13, 2024 •

edited by github-actions bot

JorTurFer commented Mar 30, 2024 •

edited by github-actions bot

JorTurFer commented Mar 30, 2024 •

edited by github-actions bot

zroubalik left a comment

JorTurFer commented Apr 10, 2024 •

edited

zroubalik commented Apr 10, 2024 •

edited by JorTurFer

Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity #5471

Are you sure you want to change the base?

Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity #5471

Conversation

JorTurFer commented Feb 2, 2024 • edited

Checklist

JorTurFer commented Feb 2, 2024 • edited by github-actions bot

JorTurFer Feb 2, 2024

Choose a reason for hiding this comment

JorTurFer commented Feb 2, 2024 • edited by github-actions bot

JorTurFer commented Feb 2, 2024 • edited by github-actions bot

JorTurFer commented Feb 2, 2024 • edited by github-actions bot

JorTurFer commented Feb 2, 2024 • edited by github-actions bot

JorTurFer commented Feb 2, 2024 • edited by github-actions bot

JorTurFer commented Feb 6, 2024 • edited by github-actions bot

JorTurFer commented Feb 6, 2024 • edited by github-actions bot

JorTurFer commented Feb 6, 2024 • edited by github-actions bot

JorTurFer commented Feb 13, 2024 • edited by github-actions bot

JorTurFer commented Mar 30, 2024 • edited by github-actions bot

JorTurFer commented Mar 30, 2024 • edited by github-actions bot

zroubalik left a comment

Choose a reason for hiding this comment

JorTurFer commented Apr 10, 2024 • edited

zroubalik commented Apr 10, 2024 • edited by JorTurFer

Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go/sdk/azidentity` #5471

Migrate old Azure SDKs into to use `github.com/Azure/azure-sdk-for-go/sdk/azidentity` #5471

JorTurFer commented Feb 2, 2024 •

edited

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 2, 2024 •

edited by github-actions bot

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

JorTurFer commented Feb 6, 2024 •

edited by github-actions bot

JorTurFer commented Feb 13, 2024 •

edited by github-actions bot

JorTurFer commented Mar 30, 2024 •

edited by github-actions bot

JorTurFer commented Mar 30, 2024 •

edited by github-actions bot

JorTurFer commented Apr 10, 2024 •

edited

zroubalik commented Apr 10, 2024 •

edited by JorTurFer