✨ Update to newer kcp apimachinery, logicalcluster packages

[fgiloux]

This brings controller-runtime to the latest kcp versions and go 1.18:

• github.com/kcp-dev/apimachinery v0.0.0-20220922165458-607ac5e87531
• github.com/kcp-dev/logicalcluster/v2 v2.0.0-alpha.3

With the new version an issue with list appeared where the index name used for the search has a trailing piple "|". A fix for it is also part of the PR.

Signed-off-by: Frederic Giloux fgiloux@redhat.com

[openshift-ci]

Hi @fgiloux. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fgiloux]

/retest

[openshift-ci]

@fgiloux: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fgiloux]

@stevekuznetsov @varshaprasad96 anything blocking the PR?
It seems that the CI test failure is not related to the code change and I don't have enough rights to trigger a retest

[ncdc]

/ok-to-test

[ncdc]

/hold

[ncdc]

The test failures are because of the upgrade to go 1.18. If you want to make that change, we'll either need to cherry-pick whatever fixed it upstream, or add an UPSTREAM: <drop>: fix go 1.18 lint errors commit w/the fixes.

[fgiloux]

The test failures are because of the upgrade to go 1.18

Thank you for pointing that out. I have cherry picked the upstream change related to the upgrade of controller-runtime from 1.17 to 1.19 (they never had 1.18).

My original idea was to align the go version here with the version used in other kcp repositories. I am not sure anymore that it is a good idea due to the divergence with the controller-runtime version. Thoughts?

[stevekuznetsov]

Let's align this with upstream controller-runtime

[fgiloux]

Let's align this with upstream controller-runtime

ack. I reverted to go 1.17

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS [ncdc,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ncdc]

/unhold