Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
Separates the test actions into unit test and integration test runs, so they can be more easily checked to see what passes and what fails. It maybe makes things take a little longer as the app has to get built multiple times, but I think it'll be helpful for seeing at a glance what's failing.
This came up from seeing a new batch of
dependabot
PRs which all failed miserably. This is really due todependabot
using a separate fork for submitting PRs - so another option might be to have the integration tests skip / fail immediately if there's no token available. Right now, they continue and just time out all over the place as they're running tokenless. The unit tests should be fine without authentication, and in fact, that's preferred.Jira Ticket / Issue
e.g. https://kbase-jira.atlassian.net/browse/DATAUP-X
DATAUP-69 Adds a PR template
)Testing Instructions
Dev Checklist:
Updating Version and Release Notes (if applicable)