Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: nixified ci times #1

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

test: nixified ci times #1

wants to merge 21 commits into from

Conversation

kayagokalp
Copy link
Owner

testing ci times

Comment on lines +77 to +79
extra_nix_config: |
extra-substituters = https://fuellabs.cachix.org
extra-trusted-public-keys = fuellabs.cachix.org-1:3gOmll82VDbT7EggylzOVJ6dr0jgPVU/KMN6+Kf8qx8=
Copy link

@sdankel sdankel Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs: https://github.com/cachix/install-nix-action#how-do-i-add-a-binary-cache

Suggested change
extra_nix_config: |
extra-substituters = https://fuellabs.cachix.org
extra-trusted-public-keys = fuellabs.cachix.org-1:3gOmll82VDbT7EggylzOVJ6dr0jgPVU/KMN6+Kf8qx8=
extra_nix_config: |
substituters = https://fuellabs.cachix.org
trusted-public-keys = fuellabs.cachix.org-1:3gOmll82VDbT7EggylzOVJ6dr0jgPVU/KMN6+Kf8qx8=

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try that!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm from this docs, it looks like providing extra_ prefix to nix config tells nix to append the given public key and substituters, rather than overriding already existing ones. In this case we overriden nixos cache and made the process slower i guess. (Since we had packages found from nixos cache rather than ours but with this change we only find the packages in our cache and re-build other ones). The default substituters is https://cache.nixos.org

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to enable experimental features here?

Copy link
Owner Author

@kayagokalp kayagokalp Jun 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the action has the flake experimental feature enabled by default, so I believe we should be good with the default settings (last bullet point in the linked section):

https://github.com/cachix/install-nix-action#features

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
kayagokalp and others added 2 commits June 8, 2023 22:23
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
@Voxelot
Copy link

Voxelot commented Jun 9, 2023

It might make sense to the github cache action to preserve /nix/store/**? Depending on the speed of the cache, it may be faster than puling from cachix.

This issue is related:
cachix/install-nix-action#165

@kayagokalp
Copy link
Owner Author

It might make sense to the github cache action to preserve /nix/store/**? Depending on the speed of the cache, it may be faster than puling from cachix.

This issue is related: cachix/install-nix-action#165

That sounds good! Let's try that, trying to put together something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants