Don't mark generated linked atomic queues as final

Reported in JCTools#208, fixed but subsequent regressed as fix edited generated source. This change should fix it permanently.
kay · Mar 3, 2019 · 0029a28 · 0029a28
1 parent 80e4e65
commit 0029a28
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...s-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicArrayQueueGenerator.java b/...s-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicArrayQueueGenerator.java
@@ -551,14 +551,16 @@ public static void main(String[] args) throws Exception {
             }
             outputFileName += ".java";
 
+            File outputFile = new File(outputDirectory, outputFileName);
             try {
-                writer = new FileWriter(new File(outputDirectory, outputFileName));
+                writer = new FileWriter(outputFile);
                 writer.write(cu.toString());
             } finally {
                 if (writer != null) {
                     writer.close();
                 }
             }
+            System.out.println("Saved to " + outputFile);
         }
     }
 

diff --git a/...-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicLinkedQueueGenerator.java b/...-build/src/main/java/org/jctools/queues/atomic/JavaParsingAtomicLinkedQueueGenerator.java
@@ -89,7 +89,6 @@ public void visit(ClassOrInterfaceDeclaration node, Void arg) {
              * Special case for MPSC
              */
             node.removeModifier(Modifier.ABSTRACT);
-            node.addModifier(Modifier.FINAL);
         }
 
         if (isCommentPresent(node, GEN_DIRECTIVE_CLASS_CONTAINS_ORDERED_FIELD_ACCESSORS)) {