Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace computed.volatile with native getter #83

Merged
merged 2 commits into from May 27, 2019
Merged

Replace computed.volatile with native getter #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538f0c4
Replace computed.volatile with native getter
pgengler May 27, 2019
1f2505e
Add explanatory comment about use of Object.defineProperty to replace…
pgengler May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 15 additions & 6 deletions addon/services/features.js
View file
Open in desktop
@@ -1,9 +1,8 @@
/*eslint-disable no-extra-boolean-cast, no-console */
import Service from '@ember/service';
import { camelize } from '@ember/string';
import { computed } from '@ember/object';

export default Service.extend({
const FeaturesService = Service.extend({

init() {
this._super(...arguments);
Expand Down Expand Up @@ -47,10 +46,6 @@ export default Service.extend({
return isEnabled;
},

flags: computed(function () {
return Object.keys(this._flags);
}).volatile(),

_resetFlags() {
this._flags = Object.create(null);
},
Expand All @@ -77,5 +72,19 @@ export default Service.extend({
unknownProperty(key) {
return this.isEnabled(key);
}
});

// Use a native getter instead of a `volatile` computed property since those
// were deprecated as of Ember 3.9. The Object.defineProperty approach (from
// https://github.com/emberjs/ember.js/issues/17709#issuecomment-469941364 is
// used because defining native getters directly on EmberObject-based classes
// is only supported from Ember 3.9 on (https://github.com/emberjs/ember.js/pull/17710)
// and this preserves compatiblity until this addon drops support for older
// Ember versions.
Object.defineProperty(FeaturesService.prototype, 'flags', {
get() {
return Object.keys(this._flags);
}
});

export default FeaturesService;