runtime-rs: Add RNG to QEMU cmdline #9639
Open
+69
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmores @gkurz @beraldoleal please review this PR |
gkurz
reviewed
May 15, 2024
gkurz
reviewed
May 15, 2024
beraldoleal
reviewed
May 15, 2024
There was a problem hiding this comment.
Hi @emanuellima1, just a small note for the future PRs:
It's best to avoid creating new PRs to replace old ones, as we might "lose" some comments and suggestions from previous reviewers. Pushing to the same PR helps track the history and progress of changes more effectively and centralizes discussions.
If a new PR is really necessary, it's helpful to tag the original reviewers to maintain continuity and ensure everyone's input was considered.
Other than @gkurz's comments, looks good to me, thanks.
pmores
reviewed
May 15, 2024
pmores
reviewed
May 16, 2024
pmores
reviewed
May 16, 2024
It creates this line, as the Golang runtime does: -object rng-random,id=rng0,filename=/dev/urandom -device virtio-rng-pci,rng=rng0 Signed-off-by: Emanuel Lima <emlima@redhat.com>
|
It doesn't seem to run when I test it: |
gkurz
reviewed
May 28, 2024
|
|
||
| object_params.push("rng-random".to_owned()); | ||
| object_params.push(format!("id={}", self.id)); | ||
| object_params.push(format!("filename={} ", self.filename)); |
There was a problem hiding this comment.
Suggested change
| object_params.push(format!("filename={} ", self.filename)); | |
| object_params.push(format!("filename={}", self.filename)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It creates this line, as the Golang runtime does:
-object rng-random,id=rng0,filename=/dev/urandom -device virtio-rng-pci,rng=rng0,max-bytes=1024,period=1000