Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: Bump nydus snapshotter to v0.13.13 #9636

Merged
merged 1 commit into from
May 16, 2024

Conversation

ChengyuZhu6
Copy link
Member

Bump nydus snapshotter to v0.13.13 to fix the gap when switching different snapshotters in guest pull.

Fixes: #8407

Bump nydus snapshotter to v0.13.13 to fix the gap when switching
different snapshotters in guest pull.

Fixes: kata-containers#8407

Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label May 15, 2024
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@fidencio
Copy link
Member

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ChengyuZhu6!

@wainersm
Copy link
Contributor

Hi all!

Not related exactly with this PR but saying here because I got your audience ;)

Looking at the non-tee job to see if this change deployed the v0.13.13 I realized that it's actually fetching the latest image (ghcr.io/containerd/nydus-snapshotter:latest):

 Normal  Scheduled  5s    default-scheduler  Successfully assigned nydus-system/nydus-snapshotter-j2vmp to aks-nodepool1-98563127-vmss000000
    Normal  Pulling    5s    kubelet            Pulling image "ghcr.io/containerd/nydus-snapshotter:latest"
    Normal  Pulled     1s    kubelet            Successfully pulled image "ghcr.io/containerd/nydus-snapshotter:latest" in 3.55s (3.55s including waiting)
    Normal  Created    1s    kubelet            Created container nydus-snapshotter
    Normal  Started    1s    kubelet            Started container nydus-snapshotter

Looking at https://github.com/containerd/nydus-snapshotter/blob/v0.13.13/misc/snapshotter/base/nydus-snapshotter.yaml#L42 .... yeah... using latest.

You know I'm a big fan of pinning versions, so I think we should pin this properly as well. I see two options here:

  1. On our CI, change the image tag before apply. Somewhere here: https://github.com/kata-containers/kata-containers/blob/main/tests/integration/kubernetes/gha-run.sh#L472
  2. Ask nydus-snapshotter community to pin the version themselves at release time (IMHO they should). In our side we implement some safe-guard, e.g., check the deployed image is the version expected

@stevenhorsman
Copy link
Member

Looking at the non-tee job to see if this change deployed the v0.13.13 I realized that it's actually fetching the latest image (ghcr.io/containerd/nydus-snapshotter:latest):

Yeah - @mkulke and I were chatting about this on slack earlier and thought that we'd either user kustomize to update the image, or ideal request the nydus-snapshotter community to pin the version, which we felt was the better solution (and then we follow that by pinning our operator image too!). So to repeat your words - we are also in agreement that the best way is to ask nydus-snapshotter for the update as part of their release process I guess?

@fidencio
Copy link
Member

@stevenhorsman, @wainersm, I fully agree, and I'm assuming we will be able to work on the items as follow-ups.
For noiw, merging this one.

@fidencio fidencio merged commit 4d073c8 into kata-containers:main May 16, 2024
299 of 313 checks passed
@ChengyuZhu6
Copy link
Member Author

Yeah - @mkulke and I were chatting about this on slack earlier and thought that we'd either user kustomize to update the image, or ideal request the nydus-snapshotter community to pin the version, which we felt was the better solution (and then we follow that by pinning our operator image too!). So to repeat your words - we are also in agreement that the best way is to ask nydus-snapshotter for the update as part of their release process I guess?

I have created a pr to fix it. containerd/nydus-snapshotter#596

@ChengyuZhu6 ChengyuZhu6 deleted the snapshotter branch May 16, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC | Issues about pulling image with vanilla containerd and remote-snapshotter
6 participants