-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version: Bump nydus snapshotter to v0.13.13 #9636
Conversation
Bump nydus snapshotter to v0.13.13 to fix the gap when switching different snapshotters in guest pull. Fixes: kata-containers#8407 Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @ChengyuZhu6!
Hi all! Not related exactly with this PR but saying here because I got your audience ;) Looking at the non-tee job to see if this change deployed the v0.13.13 I realized that it's actually fetching the
Looking at https://github.com/containerd/nydus-snapshotter/blob/v0.13.13/misc/snapshotter/base/nydus-snapshotter.yaml#L42 .... yeah... using latest. You know I'm a big fan of pinning versions, so I think we should pin this properly as well. I see two options here:
|
Yeah - @mkulke and I were chatting about this on slack earlier and thought that we'd either user kustomize to update the image, or ideal request the nydus-snapshotter community to pin the version, which we felt was the better solution (and then we follow that by pinning our operator image too!). So to repeat your words - we are also in agreement that the best way is to ask nydus-snapshotter for the update as part of their release process I guess? |
@stevenhorsman, @wainersm, I fully agree, and I'm assuming we will be able to work on the items as follow-ups. |
I have created a pr to fix it. containerd/nydus-snapshotter#596 |
Bump nydus snapshotter to v0.13.13 to fix the gap when switching different snapshotters in guest pull.
Fixes: #8407