kata-deploy: Add drop-in conf support for containerd #9499
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonkok
force-pushed
the
containerd-drop-in
branch
from
a9ea66c
to
a164ab6
Compare
c3d
reviewed
Apr 17, 2024
c3d
approved these changes
Apr 17, 2024
zvonkok
force-pushed
the
containerd-drop-in
branch
from
a164ab6
to
a076452
Compare
|
Do you have a reference for this? Would like to learn more about this containerd feature. |
|
@sprt There is some work being done on the proper merge behavior: containerd/containerd#9982 |
BbolroC
approved these changes
Apr 29, 2024
zvonkok
force-pushed
the
containerd-drop-in
branch
from
a076452
to
a6ce54a
Compare
Upcoming containerd 2.0 will have drop-in conf support. First patch to get this functionality into our stack. Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
One question here, you want to let the user decide what to do? Another thing that's crossing my mind is how we differentiate v1 / v2 / v3 when there's no configuration set, and drop-ins are used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming containerd 2.0 will have drop-in conf support. First patch to get this functionality into our stack.