Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default memory stats instead of panic. #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xueruini
Copy link

If either memory.high, memory.low, memory.max, or memory.min is not available in V2, the current code will panic, which might break user applications unintentionally. This PR tries to return the default value instead.

@Tim-Zhang Tim-Zhang requested a review from liubin July 3, 2023 14:15
@Tim-Zhang
Copy link
Member

Tim-Zhang commented Aug 1, 2023

I am not sure if it is ok to use default instead of panic, @lifupan PTAL, @liubin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants