Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft: Fail Unsupported Columns (#318) #323

Merged
merged 1 commit into from
May 9, 2023
Merged

draft: Fail Unsupported Columns (#318) #323

merged 1 commit into from
May 9, 2023

Conversation

kevinjnguyen
Copy link
Contributor

Fail Unsupported Columns (#318)

Updates the FileService and PrepareService to fail for unsupported columns (Decimal) rather than silently drop the columns.

jordanrfrazier
jordanrfrazier approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@jordanrfrazier jordanrfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sparrow changes look good to me. Whether this actually produces the error in the client-side, I'm not sure. I'd add an integration test and try that quickly (which you can do easily now with Eric's changes).

@github-actions github-actions bot added the wren label May 9, 2023
@kevinjnguyen kevinjnguyen added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 00c2c6b May 9, 2023
30 checks passed
@kevinjnguyen kevinjnguyen deleted the bug/318-dropped-parquet branch May 9, 2023 20:39
@kevinjnguyen kevinjnguyen mentioned this pull request May 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanrfrazier jordanrfrazier jordanrfrazier approved these changes

Assignees
No one assigned
Labels
sparrow wren
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinjnguyen @jordanrfrazier