Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Add empty judgment for placement in taint-manager #4959

Merged

Conversation

XiShanYongYe-Chang
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  1. Add empty judgment for placement in taint-manager, avoid panic when the obtained placement is nil:
    tolerations := placement.ClusterTolerations
  2. Add more logs to facilitate fault locating.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

In order to make the program more robust, nil judgment is added.

This is because when users define their own scheduler, the placement recorded in the annotation in the binding may be empty.

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 17, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2024
@XiShanYongYe-Chang
Copy link
Member Author

/cc @GitHubxsy @RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Add empty judgment for placement in taint-manager [Cleanup] Add empty judgment for placement in taint-manager May 17, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 53.22%. Comparing base (90b4616) to head (6bf87d0).

Files Patch % Lines
...acefuleviction/crb_graceful_eviction_controller.go 0.00% 2 Missing ⚠️
...racefuleviction/rb_graceful_eviction_controller.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
- Coverage   53.25%   53.22%   -0.03%     
==========================================
  Files         252      252              
  Lines       20514    20518       +4     
==========================================
- Hits        10925    10921       -4     
- Misses       8866     8873       +7     
- Partials      723      724       +1     
Flag Coverage Δ
unittests 53.22% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

You have to wait #4966

Signed-off-by: changzhen <changzhen5@huawei.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@karmada-bot karmada-bot merged commit 21b3ffe into karmada-io:master May 21, 2024
12 checks passed
@XiShanYongYe-Chang XiShanYongYe-Chang deleted the add-empty-judgement branch June 7, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants