-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Add empty judgment for placement in taint-manager #4959
[Cleanup] Add empty judgment for placement in taint-manager #4959
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
- Coverage 53.25% 53.22% -0.03%
==========================================
Files 252 252
Lines 20514 20518 +4
==========================================
- Hits 10925 10921 -4
- Misses 8866 8873 +7
- Partials 723 724 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6bf87d0
to
a42181c
Compare
You have to wait #4966 |
Signed-off-by: changzhen <changzhen5@huawei.com>
a42181c
to
dcd04ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
karmada/pkg/controllers/cluster/taint_manager.go
Line 267 in 90b4616
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
In order to make the program more robust, nil judgment is added.
This is because when users define their own scheduler, the placement recorded in the annotation in the binding may be empty.
Does this PR introduce a user-facing change?: