Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: adjust log print content when delete token by karmadactl #4956

Merged
merged 1 commit into from
May 21, 2024

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cleanup: adjust log print content when delete token by karmadactl.

These logs are misleading for users and security scanning tools, and can easily be mistaken for sensitive information such as printing tokenID.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 17, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.35%. Comparing base (41aef43) to head (52cd771).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4956      +/-   ##
==========================================
+ Coverage   53.34%   53.35%   +0.01%     
==========================================
  Files         252      252              
  Lines       20478    20478              
==========================================
+ Hits        10923    10926       +3     
+ Misses       8833     8831       -2     
+ Partials      722      721       -1     
Flag Coverage Δ
unittests 53.35% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member

cc @zhzhuang-zju to take a look

@zhzhuang-zju
Copy link
Contributor

/assign

pkg/karmadactl/token/token.go Outdated Show resolved Hide resolved
pkg/karmadactl/token/token.go Outdated Show resolved Hide resolved
@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2024
@chaosi-zju
Copy link
Member Author

CC @RainbowMango

@RainbowMango
Copy link
Member

@zhzhuang-zju Do you have any further comments?

@chaosi-zju we need to wait #4966

Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
@zhzhuang-zju
Copy link
Contributor

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@zhzhuang-zju
Copy link
Contributor

cc @RainbowMango

@chaosi-zju
Copy link
Member Author

I have rebased #4966.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@karmada-bot karmada-bot merged commit 53af52e into karmada-io:master May 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants