Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kube version #3489

Merged
merged 1 commit into from May 4, 2023

Conversation

ibalajiarun
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR upgrades the kube images to v1.25.4 to fix this issue kubernetes/kubernetes#111985 in v1.25 of kubernetes.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label May 2, 2023
@karmada-bot
Copy link
Collaborator

Welcome @ibalajiarun! It looks like this is your first PR to karmada-io/karmada 🎉

@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 2, 2023
Signed-off-by: Balaji Arun <balajia@vt.edu>
@codecov-commenter
Copy link

Codecov Report

Merging #3489 (f132abf) into master (b841c54) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   53.61%   53.60%   -0.02%     
==========================================
  Files         210      210              
  Lines       19182    19182              
==========================================
- Hits        10284    10282       -2     
- Misses       8345     8347       +2     
  Partials      553      553              
Flag Coverage Δ
unittests 53.60% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/karmadactl/cmdinit/cmdinit.go 73.41% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot
/lgtm
/kind cleanup

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. labels May 3, 2023
@ibalajiarun
Copy link
Contributor Author

/assign @kevin-wangzefeng

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@karmada-bot karmada-bot merged commit 7843bc8 into karmada-io:master May 4, 2023
13 checks passed
@ibalajiarun ibalajiarun deleted the balaji/k8s-image-tag branch June 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants