Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller runtime to v0.8.3 and k8s to v1.20.6 #296

Merged

Conversation

RainbowMango
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Update controller runtime to v0.7.2 which depends on Kubernetes v1.19+ and supports proxy.

Which issue(s) this PR fixes:
Refer #257

Special notes for your reviewer:

  1. Updated admission review version from v1beta1 to v1.

Does this PR introduce a user-facing change?:

NONE

@RainbowMango
Copy link
Member Author

RainbowMango commented Apr 29, 2021

A data race found from e2e test:

==================
WARNING: DATA RACE
Write at 0x00c0004c1960 by goroutine 8:
  sigs.k8s.io/controller-runtime/pkg/log.(*loggerPromise).Fulfill()
      /root/go/src/github.com/karmada-io/karmada/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:75 +0xef
  sigs.k8s.io/controller-runtime/pkg/log.(*DelegatingLogger).Fulfill()
      /root/go/src/github.com/karmada-io/karmada/vendor/sigs.k8s.io/controller-runtime/pkg/log/deleg.go:124 +0x12e
  sigs.k8s.io/controller-runtime/pkg/log.init.0.func1()
      /root/go/src/github.com/karmada-io/karmada/vendor/sigs.k8s.io/controller-runtime/pkg/log/log.go:67 +0xbb

Previous read at 0x00c0004c1960 by main goroutine:
  [failed to restore the stack]

This issue is fixed by kubernetes-sigs/controller-runtime#1339 in controller-runtime@v0.8.1
Also there is a fix in v0.8.2 by kubernetes-sigs/controller-runtime#1361.

@RainbowMango
Copy link
Member Author

Hold for kubernetes-sigs/controller-runtime#1497.

@RainbowMango RainbowMango force-pushed the pr_update_controller_runtime branch from e7b4668 to c1b37cf Compare May 8, 2021 08:52
@RainbowMango RainbowMango changed the title Update controller runtime to v0.7.2 Update controller runtime to v0.8.3 and k8s to v1.20.2 May 8, 2021
@kevin-wangzefeng
Copy link
Member

The latest release for Kubernetes 1.20 is 1.20.6, I would suggest upgrade to 1.20.6 directly.
And we should not really use any 1.x.y (y<=5) releases of upstream Kubernetes which are typically not quite stable.

@kevin-wangzefeng
Copy link
Member

/hold

bump kubernetes dependency to v1.20.6

Signed-off-by: RainbowMango <renhongcai@huawei.com>
Adopt MapOjbect removing change
Adopt event handling object changes
Adopt ToRequestsFunc to MapFunc change
Adopt EnqueueRequestsFromMapFunc change
Adopt runerable interface change
Adopt using admission review version v1

Signed-off-by: RainbowMango <renhongcai@huawei.com>
@RainbowMango RainbowMango force-pushed the pr_update_controller_runtime branch from c1b37cf to 28afae3 Compare May 8, 2021 09:47
@RainbowMango RainbowMango changed the title Update controller runtime to v0.8.3 and k8s to v1.20.2 Update controller runtime to v0.8.3 and k8s to v1.20.6 May 8, 2021
@RainbowMango
Copy link
Member Author

Updated to v1.20.6.
/unhold :) :) :)

@RainbowMango RainbowMango merged commit 763c2a1 into karmada-io:master May 8, 2021
@RainbowMango RainbowMango deleted the pr_update_controller_runtime branch May 8, 2021 11:12
jwcesign pushed a commit to jwcesign/karmada that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants