Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(configuration-file): document async function #3761

Merged
merged 1 commit into from Apr 8, 2022

Conversation

nicojs
Copy link
Contributor

@nicojs nicojs commented Feb 11, 2022

See #3660

@devoto13
Copy link
Collaborator

There is already a PR in flight to document async config. I'm not sure whether it is best to present an example with old-school promise, async function, or both. I'm leaning towards the async function example as more modern and readable. So I think we can rebase it once the other PR is merged as it provides more info about the feature.

@nicojs
Copy link
Contributor Author

nicojs commented Feb 11, 2022

I didn't see that PR, sorry about that.

JS Devs in 2022 know what an async function is and what a Promise is. Adding this small example should be enough IMHO.

@devoto13
Copy link
Collaborator

Yeah, maybe you're right and we don't need to provide so many details about the async config.

@jginsburgn Are you fine merging this instead of #3733?

@jginsburgn jginsburgn merged commit 7aeb3f8 into karma-runner:master Apr 8, 2022
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.3.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants