Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): check extension before ts-node register #3651

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

xel23
Copy link
Contributor

@xel23 xel23 commented Feb 8, 2021

Call require('ts-node').register() after checking configFilePath has .ts extension

Fixes #3329

сс @devoto13

Call require('ts-node').register() after checking configFilePath has `.ts` extension

Fixes karma-runner#3329
@google-cla
Copy link

google-cla bot commented Feb 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AppVeyorBot
Copy link

Build karma 2927 completed (commit 4157266d7a by @xel23)

@karmarunnerbot
Copy link
Member

Build karma 530 completed (commit 4157266d7a by @xel23)

@karmarunnerbot
Copy link
Member

Build karma 529 completed (commit 4157266d7a by @xel23)

@devoto13
Copy link
Collaborator

devoto13 commented Feb 8, 2021

@xel23 Thanks for the PR!

I guess we can land it as a workaround to solve the most painful appearance of this issue, but I don't think it "fixes" the issue. We really should implement a systematic solution as outlined in #3329 (comment).

Technically this is a breaking change. People, who might have relied on type-checking their karma.conf.js with allowJS: true will no longer have the type-checking. As this does not prevent them from running Karma, I am willing to do so to resolve the issue for the majority of users. @johnjbarton What do you think?

@maksimr
Copy link
Contributor

maksimr commented Feb 11, 2021

Ping

@johnjbarton johnjbarton merged commit 474f4e1 into karma-runner:master Feb 12, 2021
karmarunnerbot pushed a commit that referenced this pull request Feb 12, 2021
## [6.1.1](v6.1.0...v6.1.1) (2021-02-12)

### Bug Fixes

* **config:** check extension before ts-node register ([#3651](#3651)) ([474f4e1](474f4e1)), closes [#3329](#3329)
* report launcher process error when exit event is not emitted ([#3647](#3647)) ([7ab86be](7ab86be))
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jimbojw
Copy link

jimbojw commented Feb 12, 2021

Thank you so much for fixing this! 🥳 🎉

This was referenced Mar 15, 2021
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Call require('ts-node').register() after checking configFilePath has `.ts` extension

Fixes karma-runner#3329
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
## [6.1.1](karma-runner/karma@v6.1.0...v6.1.1) (2021-02-12)

### Bug Fixes

* **config:** check extension before ts-node register ([karma-runner#3651](karma-runner#3651)) ([474f4e1](karma-runner@474f4e1)), closes [karma-runner#3329](karma-runner#3329)
* report launcher process error when exit event is not emitted ([karma-runner#3647](karma-runner#3647)) ([7ab86be](karma-runner@7ab86be))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable ts-node?
7 participants