Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): clean up vestigial code from proxy #3640

Merged
merged 2 commits into from Jun 1, 2021
Merged

fix(server): clean up vestigial code from proxy #3640

merged 2 commits into from Jun 1, 2021
+41 −37

Commits on Apr 27, 2021

  1. fix(server/proxy): clean up unused logic 

    fix(server/proxy): config.protocol can control connection scheme

fix(server/proxy): clean up unused logic
    Jonathan Ginsburg authored and Jonathan Ginsburg committed Apr 27, 2021
    Copy the full SHA
    a05774e View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. fix(server): clean up vestigial code from proxy 

    When using the proxy feature of Karma, the target value can include the [scheme](https://tools.ietf.org/html/std66#section-3.1). It was used to determine the `https` variable to be sent to the [`http-proxy`](https://www.npmjs.com/package/http-proxy) `.createProxyServer` method. However, it is now disregarded by that package. Therefore, this PR cleans it up.
    Jonathan Ginsburg committed May 5, 2021
    Copy the full SHA
    3556ebd View commit details
    Browse the repository at this point in the history