Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: replace validate-commit-msg with commitlint on Travis #3523

Merged
merged 1 commit into from May 20, 2020
Merged

ci: replace validate-commit-msg with commitlint on Travis #3523

merged 1 commit into from May 20, 2020

Commits on May 19, 2020

  1. ci: replace validate-commit-msg with commitlint on Travis 

    Former is [deprecated](https://www.npmjs.com/package/validate-commit-msg) in favor of later. Karma already uses commitlint + husky to do commit validation locally. Added a dedicated package to simplify Travis integration as described in the commitlint [documentation](https://commitlint.js.org/#/guides-ci-setup).

As a bonus it provides a good error message when Travis fails because of the bad commit message ([example](https://travis-ci.org/github/karma-runner/karma/jobs/688059354#L92)).
    @devoto13
    devoto13 committed May 19, 2020
    Copy the full SHA
    04efadd View commit details
    Browse the repository at this point in the history