Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): add common method to start server in background #3495

Merged
merged 1 commit into from
May 5, 2020
Merged

refactor(test): add common method to start server in background #3495

merged 1 commit into from
May 5, 2020

Commits on May 5, 2020

  1. refactor(test): add common method to start server in background 

    The existing code had pretty confusing logic (old lines 33-36)`: when background server start fails it is actually considered a success, but child process is not started. Because of this `lastRun` contains result output of the `karma start`. This is no longer the case, hence two test cases had to be updated as they never executed `karma run` despite the statement and were asserting against `karma start` output. This should be more clear now.

As background server process now has its own variable to store output, there is no need for a dedicated runOut command and it can be removed.
    @devoto13
    devoto13 committed May 5, 2020
    Configuration menu
    Copy the full SHA
    11a3348 View commit details
    Browse the repository at this point in the history