fix(client): prevent race condition in clear context #3425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 91 completed (commit e93c6c177d by @nicojs) |
|
✅ Build karma 90 completed (commit e93c6c177d by @nicojs) |
|
✅ Build karma 2489 completed (commit e93c6c177d by @nicojs) |
nicojs
force-pushed
the
fix/race-condition-in-clear-context
branch
from
4f47465
to
4767154
Compare
|
✅ Build karma 110 completed (commit 620637fb91 by @nicojs) |
|
✅ Build karma 2508 completed (commit 620637fb91 by @nicojs) |
|
✅ Build karma 109 completed (commit 620637fb91 by @nicojs) |
johnjbarton
suggested changes
Mar 18, 2020
| } else { | ||
| iframe.src = policy.createURL(url) | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Schedules te next execution after current context is cleared |
| this.scheduleExecution = function (execution) { | ||
| if (reloadingContext) { | ||
| // A context reload is in progress. Wait for it to complete before executing. | ||
| this.scheduledExecution = execution |
There was a problem hiding this comment.
I think this one character member name difference is hard to read, could we use eg executionScheduled?
| * Schedules te next execution after current context is cleared | ||
| * (or is directly started if context is currently not being cleared) | ||
| * @param execution {() => void} | ||
| * @see https://github.com/karma-runner/karma/issues/3424 |
There was a problem hiding this comment.
Please also add
Fixes #3424
to the PR description.
|
I think #3597 will fix this, but time will tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3424