refactor: make the preprocesor as full async method #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build karma 2429 completed (commit eb94bc3c39 by @anthony-redFox) |
|
✅ Build karma 31 completed (commit eb94bc3c39 by @anthony-redFox) |
|
✅ Build karma 30 completed (commit eb94bc3c39 by @anthony-redFox) |
|
sure, I will take a look |
|
❌ Build karma 2438 failed (commit a5a44a5d56 by @johnjbarton) |
johnjbarton
suggested changes
Oct 21, 2019
|
❌ Build karma 40 failed (commit a5a44a5d56 by @johnjbarton) |
|
❌ Build karma 39 failed (commit a5a44a5d56 by @johnjbarton) |
update isbinaryfile on async version
anthony-redFox
force-pushed
the
preproc
branch
from
df128bf
to
db52c39
Compare
|
✅ Build karma 42 completed (commit 86a944dda9 by @anthony-redFox) |
|
✅ Build karma 41 completed (commit 86a944dda9 by @anthony-redFox) |
johnjbarton
approved these changes
Oct 22, 2019
|
✅ Build karma 2440 completed (commit 86a944dda9 by @anthony-redFox) |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update isbinaryfile on async version