chore: update var to let/const #3224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjbarton
approved these changes
Dec 5, 2018
|
The changelog tool wants the changes to match |
jniles
force-pushed
the
chore-update-var-to-node-v4-level
branch
from
f5ce540
to
8438b85
Compare
Updates the remaining server `var`s to `let` or `const`.
jniles
force-pushed
the
chore-update-var-to-node-v4-level
branch
from
8438b85
to
9662d46
Compare
|
Seems like tests fails with these changes. I had same issues, but didn't spent enough time to investigate why. If you would check it, it would be valuable knowledge for everyone :) |
|
Sorry this did not work out. I'm going to close a lot of older pull requests as the source code has changed a lot over the last year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the remaining server
vars tolet/constas discussed in #3151.