Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change puppeteer from dependency to dev-dependency #3192

Closed
wants to merge 1 commit into from
Closed

fix: Change puppeteer from dependency to dev-dependency #3192

wants to merge 1 commit into from

Conversation

davidshepherd7
Copy link

Closes #3191

johnjbarton
johnjbarton approved these changes Oct 22, 2018
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@johnjbarton
Copy link
Contributor

Without the CLA we can't land this.

@johnjbarton
Copy link
Contributor

Please see #3193

@davidshepherd7
Copy link
Author

Oh sorry I was asleep, thanks for getting a fix in anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidshepherd7 @johnjbarton