Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware): simplify stripHost. #3115

Merged
merged 1 commit into from Sep 6, 2018
Merged

fix(middleware): simplify stripHost. #3115

merged 1 commit into from Sep 6, 2018

Commits on Aug 17, 2018

  1. fix(middleware): simplify stripHost. 

    The stripHost middleware only adds a modified url to the request.
That modified url is only used one place. By converting the middleware
to a module, the code is simpler and beforeMiddleware modules can reuse
karma middleware. (One alternative considered was to move the stripHost
in the chain before the beforeMiddleware, but this form seems better).

Clean up regex per offline suggestion from zzo@
    @johnjbarton
    johnjbarton committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    32ae9b5 View commit details
    Browse the repository at this point in the history