fix(server): clear web server close timeout on clean close #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
@pkozlowski-opensource thanks, lgtm too |
|
Good catch, simple fix. |
|
Nice. Sending to presubmit queue.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Karma server shuts down it also closes a web server it started. In order to properly close the started web server, there is a setTimeout of 3s that should execute cleanup operations when a web server doesn't close cleanly. Unfortunately this fallback timeout is not canceled when a web server does close cleanly, preventing karma process from exiting for 3s.
This PR fixes this by cancelling the fallback timeout in the clan close callback.
This is is part of many fixes we need to do in order to fix #1035