ci: replace validate-commit-msg with commitlint on Travis #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former is [deprecated](https://www.npmjs.com/package/validate-commit-msg) in favor of later. Karma already uses commitlint + husky to do commit validation locally. Added a dedicated package to simplify Travis integration as described in the commitlint [documentation](https://commitlint.js.org/#/guides-ci-setup). As a bonus it provides a good error message when Travis fails because of the bad commit message ([example](https://travis-ci.org/github/karma-runner/karma/jobs/688059354#L92)).
|
✅ Build karma 298 completed (commit 6cbb2eccea by @devoto13) |
|
✅ Build karma 297 completed (commit 6cbb2eccea by @devoto13) |
johnjbarton
approved these changes
May 20, 2020
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
anthony-redFox
pushed a commit
to anthony-redFox/karma
that referenced
this pull request
May 16, 2023
…er#3523) Former is [deprecated](https://www.npmjs.com/package/validate-commit-msg) in favor of later. Karma already uses commitlint + husky to do commit validation locally. Added a dedicated package to simplify Travis integration as described in the commitlint [documentation](https://commitlint.js.org/#/guides-ci-setup). As a bonus it provides a good error message when Travis fails because of the bad commit message ([example](https://travis-ci.org/github/karma-runner/karma/jobs/688059354#L92)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Former is deprecated in favor of later. Karma already uses commitlint + husky to do commit validation locally. Added a dedicated package to simplify Travis integration as described in the commitlint documentation.
As a bonus it provides a detailed error message when Travis fails because of the bad commit message (example).