fix(test): test:client silently failing on Travis (#3343)

* fix(test): ensure that grunt test:client exits with non-zero code Apparently it is not enough to check `code`, because when process crashes `code` is set to `null` and `err` is passed instead. Example of failing tests, which didn't fail build: https://travis-ci.org/karma-runner/karma/jobs/537027667#L1046 * fix(test): adjust assertions to work in latest Chrome
karma-runner · Jul 26, 2019 · 1489e9a · 1489e9a
1 parent 094bcc6
commit 1489e9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tasks/test.js b/tasks/test.js
@@ -26,7 +26,7 @@ module.exports = function (grunt) {
 
     function exec (args, failMsg) {
       spawnKarma(args, function (err, result, code) {
-        if (code) {
+        if (code || err) {
           console.error(err)
           grunt.fail.fatal(failMsg, code)
         } else {

diff --git a/test/e2e/error.feature b/test/e2e/error.feature
@@ -16,7 +16,7 @@ Feature: Error Display
     When I start Karma
     Then it fails with:
       """
-      SyntaxError: Unexpected token }
+      SyntaxError: Unexpected token '}'
       """
   Scenario: Not single-run Syntax Error in a test file
     Given a configuration with:
@@ -32,5 +32,5 @@ Feature: Error Display
     When I runOut Karma
     Then it fails with like:
       """
-      SyntaxError: Unexpected token }
+      SyntaxError: Unexpected token '}'
       """