Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI/CD with GitHub Actions #274

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add CI/CD with GitHub Actions #274

wants to merge 7 commits into from

Conversation

wswebcreation
Copy link
Collaborator

This PR is based on karma-runner/karma-chrome-launcher#249 based on @jginsburgn [his feedback]((#256 (comment)).

@jginsburgn

Do you still have the Sauce Labs credentials? If not then please let me know and I can see if I can find them.

@wswebcreation
chore: add cicd with gha
e08ba3a 
- add GHA
- remove travis
- add update contributors list
@wswebcreation wswebcreation mentioned this pull request Aug 29, 2022
Merged
jginsburgn
jginsburgn reviewed Sep 23, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jginsburgn
Copy link
Member

Sorry for my delayed review :/

wswebcreation
wswebcreation commented Sep 25, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@wswebcreation
Copy link
Collaborator Author

wswebcreation commented Sep 25, 2022 •
edited

Sorry for my delayed review :/

No problem @jginsburgn

I've fixed the comment, can you check again and merge if possible? Then we can release a new version. Tnx
By the way, can you also add the credentials to the repo so it will work. If you don't have them then please mail me on wim.selles@saucelabs.com?

wswebcreation and others added 2 commits September 26, 2022 16:59
@wswebcreation
chore: add cicd with gha
65b39ed 
- add GHA
- remove travis
- add update contributors list
chore: also build in the "Test" CI workflow
c8b5723
@wswebcreation
Copy link
Collaborator Author

@jginsburgn

I've updated everything, can you add the sauce username and accesskey to the repo. If you don't have them then please let me know, I can mail them to you

@wswebcreation wswebcreation mentioned this pull request Nov 4, 2022
Open
@wswebcreation
Copy link
Collaborator Author

@jginsburgn

Do you have some time to look at this, not having the credentials in the pipeline is blocking all future releases

@apepper
Copy link

apepper commented Dec 8, 2022

@jginsburgn It would be great, if this PR can move forward.

@jginsburgn
Copy link
Member

Hey!

I am sorry I have been unable to take care of this. FYI I have changed teams and no longer own the Karma project. The right handle to ping is @karma-runner/google-web-test-team!

@apepper
Copy link

apepper commented Dec 19, 2022

@karma-runner/google-web-test-team any chance of seeing this PR merge? It adds GitHub Actions to karma-sauce-launcher in order to run automatic tests and automatic release management.

@Hdom
Copy link

Hdom commented Feb 24, 2023

Hello, any progress on this?

@Havunen
Copy link

Havunen commented Nov 3, 2023 •
edited

I have created a fork of this plugin and published it to npm where latest versions of dependencies are upgraded havunen-karma-sauce-launcher2 https://github.com/Havunen/karma-sauce-launcher/tree/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Havunen Havunen Havunen left review comments

@jginsburgn jginsburgn jginsburgn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wswebcreation @jginsburgn @apepper @Hdom @Havunen