Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return false for every entry is irrelevant #206

Merged
merged 2 commits into from May 4, 2018
Merged

fix: return false for every entry is irrelevant #206

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4a573e
fix: return false for every entry is irrelevant
yinm Apr 28, 2018
c25a0b8
Add a comment
yinm May 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/adapter.spec.js
View file
Open in desktop
Expand Up @@ -465,7 +465,7 @@ describe('jasmine adapter', function () {
})

it('should return the all stack entries if every entry is irrelevant', function () {
spyOn(window, 'isExternalStackEntry').and.returnValue(true)
spyOn(window, 'isExternalStackEntry').and.returnValue(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here as the two cases are confusing (which is why the bug was in the code). For example:

// Check the case where the filteredStack is empty

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I committed at c25a0b8

expect(getRelevantStackFrom('a\nb\nc')).toEqual(['a', 'b', 'c'])
})

Expand Down