Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect function and its call. #183

Merged
merged 1 commit into from Mar 29, 2018
Merged

Remove incorrect function and its call. #183

merged 1 commit into from Mar 29, 2018

Commits on Mar 29, 2018

  1. fix(adapter): Remove incorrect function and its call. 

    The string tested in the function isTopLevelSuite() is not used in jasmine. The
correct string would be Jasmine__TopLevel__Suite (two underscores). So the function
always returns false, and we negate it at the call site, to the child is always
added. That's the correct behavior because we already have a root node matching
the Jasmine top level suite. The test and the function is unnecessary.
    @johnjbarton
    johnjbarton committed Mar 29, 2018
    Copy the full SHA
    ba7b5cf View commit details
    Browse the repository at this point in the history